Valódi tesztelés közben előkerült eset (két aktív gyártó, pl. "Szarvas" és "Szarvasi"): az alias-felvétel eddig csak elutasította az ütközést, de nem adott módot a tényleges összevonásra a felületről - csak a producers:dedupe-report -> Excel -> producers:dedupe --apply láncon keresztül, fejlesztői hozzáféréssel. Új "Gyártó összevonása" gomb a megtekintő oldalon: a nézett gyártó marad a keeper, a kiválasztott aktív gyártó beolvad, a neve automatikusan aliasként kerül fel. A ProducerDeduplicator::apply() egyetlen kézzel épített merge-bejegyzéssel hívva, Excel nélkül. A jelentés fájlba írása kiemelve a CLI parancsból, hogy a felületi összevonás is CLI-vel visszagörgethető maradjon. Az alias-ütközés hibaüzenete (ha aktív gyártóval ütközik) mostantól a dedikált ActiveProducerNameCollisionException-on át utal az összevonás gombra. Mellékesen javítva: a jelentés-fájlnév másodperc pontosságú volt, ami egy másodpercen belüli két összevonásnál csendben felülírta volna az előzőt (mikroszekundumra pontosítva), és az Aliasok relation manager nem frissült a más komponensről történő összevonás után (5s poll, ugyanaz a minta, mint a LinesRelationManager-en).
200 lines
7.7 KiB
PHP
200 lines
7.7 KiB
PHP
<?php
|
|
|
|
use App\Enums\DbStatusFieldEnum;
|
|
use App\Filament\Resources\Producers\Pages\ListProducers;
|
|
use App\Filament\Resources\Producers\Pages\ViewProducer;
|
|
use App\Filament\Resources\Producers\ProducerResource;
|
|
use App\Filament\Resources\Producers\RelationManagers\AliasesRelationManager;
|
|
use App\Models\Producer;
|
|
use App\Models\ProducerAlias;
|
|
use App\Models\Product;
|
|
use App\Models\Role;
|
|
use App\Models\User;
|
|
use Filament\Actions\CreateAction;
|
|
use Filament\Actions\DeleteAction;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Livewire\Livewire;
|
|
use Tests\TestCase;
|
|
|
|
uses(TestCase::class, RefreshDatabase::class);
|
|
|
|
function actAsDeveloperForProducers(): User
|
|
{
|
|
$devRole = Role::firstOrCreate(['name' => 'developer'], ['display_name' => 'Developer']);
|
|
$developer = User::factory()->create();
|
|
$developer->addRole($devRole);
|
|
|
|
return $developer;
|
|
}
|
|
|
|
test('a gyártó lista oldal renderel', function () {
|
|
$this->actingAs(actAsDeveloperForProducers());
|
|
|
|
Producer::create(['name' => 'Danone', 'status' => DbStatusFieldEnum::active, 'canSee' => 1]);
|
|
|
|
Livewire::test(ListProducers::class)->assertSuccessful();
|
|
});
|
|
|
|
test('a gyártó megtekintő oldal az alias relation managerrel együtt renderel', function () {
|
|
$this->actingAs(actAsDeveloperForProducers());
|
|
|
|
$producer = Producer::create(['name' => 'Danone', 'status' => DbStatusFieldEnum::active, 'canSee' => 1]);
|
|
ProducerAlias::create([
|
|
'producer_id' => $producer->id,
|
|
'name' => 'Danone ',
|
|
'normalized_name' => 'DANONE',
|
|
'source' => 'backfill',
|
|
]);
|
|
|
|
Livewire::test(ViewProducer::class, ['record' => $producer->getRouteKey()])
|
|
->assertSuccessful()
|
|
->assertSee('Danone ');
|
|
});
|
|
|
|
test('a relation manageren keresztül felvett alias ütközését a form visszautasítja', function () {
|
|
$this->actingAs(actAsDeveloperForProducers());
|
|
|
|
Producer::create(['name' => 'Bonduelle', 'status' => DbStatusFieldEnum::active, 'canSee' => 1]);
|
|
$producer = Producer::create(['name' => 'Danone', 'status' => DbStatusFieldEnum::active, 'canSee' => 1]);
|
|
|
|
Livewire::test(AliasesRelationManager::class, [
|
|
'ownerRecord' => $producer,
|
|
'pageClass' => ViewProducer::class,
|
|
])
|
|
->callTableAction(CreateAction::class, data: ['name' => 'Bonduelle'])
|
|
->assertHasTableActionErrors(['name']);
|
|
|
|
expect(ProducerAlias::count())->toBe(0);
|
|
});
|
|
|
|
test('a relation manageren keresztül felvett alias létrejön és a normalizált név is elmentődik', function () {
|
|
$this->actingAs(actAsDeveloperForProducers());
|
|
|
|
$producer = Producer::create(['name' => 'Danone', 'status' => DbStatusFieldEnum::active, 'canSee' => 1]);
|
|
|
|
Livewire::test(AliasesRelationManager::class, [
|
|
'ownerRecord' => $producer,
|
|
'pageClass' => ViewProducer::class,
|
|
])->callTableAction(CreateAction::class, data: ['name' => 'Danone Kft']);
|
|
|
|
$alias = ProducerAlias::where('producer_id', $producer->id)->sole();
|
|
|
|
expect($alias->name)->toBe('Danone Kft')
|
|
->and($alias->normalized_name)->toBe('DANONE KFT')
|
|
->and($alias->source)->toBe('manual');
|
|
});
|
|
|
|
test('a relation managerben az alias törölhető', function () {
|
|
$this->actingAs(actAsDeveloperForProducers());
|
|
|
|
$producer = Producer::create(['name' => 'Danone', 'status' => DbStatusFieldEnum::active, 'canSee' => 1]);
|
|
$alias = ProducerAlias::create([
|
|
'producer_id' => $producer->id,
|
|
'name' => 'Danone Kft',
|
|
'normalized_name' => 'DANONE KFT',
|
|
'source' => 'backfill',
|
|
]);
|
|
|
|
Livewire::test(AliasesRelationManager::class, [
|
|
'ownerRecord' => $producer,
|
|
'pageClass' => ViewProducer::class,
|
|
])->callTableAction(DeleteAction::class, record: $alias);
|
|
|
|
expect(ProducerAlias::count())->toBe(0);
|
|
});
|
|
|
|
test('a Gyártó összevonása gomb csak aktív gyártónál látszik', function () {
|
|
$this->actingAs(actAsDeveloperForProducers());
|
|
|
|
$active = Producer::create(['name' => 'Danone', 'status' => DbStatusFieldEnum::active, 'canSee' => 1]);
|
|
$archived = Producer::create(['name' => 'Danone Kft', 'status' => DbStatusFieldEnum::archive, 'canSee' => 0]);
|
|
|
|
Livewire::test(ViewProducer::class, ['record' => $active->getRouteKey()])
|
|
->assertActionVisible('mergeProducer');
|
|
|
|
Livewire::test(ViewProducer::class, ['record' => $archived->getRouteKey()])
|
|
->assertActionHidden('mergeProducer');
|
|
});
|
|
|
|
test('a Gyártó összevonása gomb ténylegesen összevonja a két aktív gyártót', function () {
|
|
$this->actingAs(actAsDeveloperForProducers());
|
|
|
|
$reportsBefore = collect(glob(storage_path('app/private/producers-dedupe-*.json')));
|
|
|
|
$keeper = Producer::create(['name' => 'Szarvasi', 'status' => DbStatusFieldEnum::active, 'canSee' => 1]);
|
|
$loser = Producer::create(['name' => 'Szarvas', 'status' => DbStatusFieldEnum::active, 'canSee' => 1]);
|
|
$product = Product::create([
|
|
'name' => 'Teszt termék',
|
|
'supplierProductNumber' => 'SKU1',
|
|
'producer_id' => $loser->id,
|
|
'unitValue' => 1,
|
|
'note' => '',
|
|
'status' => DbStatusFieldEnum::active,
|
|
'canSee' => 1,
|
|
]);
|
|
|
|
Livewire::test(ViewProducer::class, ['record' => $keeper->getRouteKey()])
|
|
->callAction('mergeProducer', data: ['loser_id' => $loser->id]);
|
|
|
|
expect($loser->refresh()->status)->toBe(DbStatusFieldEnum::archive)
|
|
->and($loser->note)->toContain('Összevonva ide: #' . $keeper->id)
|
|
->and($keeper->refresh()->name)->toBe('Szarvasi') // nincs átnevezés
|
|
->and($product->refresh()->producer_id)->toBe($keeper->id);
|
|
|
|
$alias = ProducerAlias::where('producer_id', $keeper->id)->sole();
|
|
expect($alias->name)->toBe('Szarvas');
|
|
|
|
collect(glob(storage_path('app/private/producers-dedupe-*.json')))
|
|
->diff($reportsBefore)
|
|
->each(fn ($path) => @unlink($path));
|
|
});
|
|
|
|
test('a felületi összevonás jelentés-fájlt ír, ami CLI-vel visszagörgethető', function () {
|
|
$this->actingAs(actAsDeveloperForProducers());
|
|
|
|
$keeper = Producer::create(['name' => 'Szarvasi', 'status' => DbStatusFieldEnum::active, 'canSee' => 1]);
|
|
$loser = Producer::create(['name' => 'Szarvas', 'status' => DbStatusFieldEnum::active, 'canSee' => 1]);
|
|
|
|
$before = collect(glob(storage_path('app/private/producers-dedupe-*.json')));
|
|
|
|
Livewire::test(ViewProducer::class, ['record' => $keeper->getRouteKey()])
|
|
->callAction('mergeProducer', data: ['loser_id' => $loser->id]);
|
|
|
|
$after = collect(glob(storage_path('app/private/producers-dedupe-*.json')));
|
|
$newFiles = $after->diff($before);
|
|
|
|
expect($newFiles)->toHaveCount(1);
|
|
|
|
$report = json_decode(file_get_contents($newFiles->first()), true);
|
|
expect($report['merges'][0]['keeper_id'])->toBe($keeper->id);
|
|
|
|
app(\App\Services\ProducerDeduplicator::class)->rollback($report);
|
|
|
|
expect($loser->refresh()->status)->toBe(DbStatusFieldEnum::active);
|
|
|
|
@unlink($newFiles->first());
|
|
});
|
|
|
|
test('a relation manager elutasítja az aktív gyártóval ütköző alias-t', function () {
|
|
$this->actingAs(actAsDeveloperForProducers());
|
|
|
|
Producer::create(['name' => 'Szarvas', 'status' => DbStatusFieldEnum::active, 'canSee' => 1]);
|
|
$producer = Producer::create(['name' => 'Szarvasi', 'status' => DbStatusFieldEnum::active, 'canSee' => 1]);
|
|
|
|
Livewire::test(AliasesRelationManager::class, [
|
|
'ownerRecord' => $producer,
|
|
'pageClass' => ViewProducer::class,
|
|
])
|
|
->callTableAction(CreateAction::class, data: ['name' => 'Szarvas'])
|
|
->assertHasTableActionErrors(['name']);
|
|
|
|
expect(ProducerAlias::count())->toBe(0);
|
|
});
|
|
|
|
test('csak azoknak a szerepköröknek látszik a menüpont, akik elérik az admin felületet', function () {
|
|
$developer = actAsDeveloperForProducers();
|
|
|
|
$this->actingAs($developer);
|
|
$this->get(ProducerResource::getUrl())->assertOk();
|
|
});
|